-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[HttpFoundation] Drop int return type from parseFilesize() #39633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PHP on 32bit is still a thing, apparently. 🤔
@derrabus apparently. Wouldn't recommend it personally but 🤷 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add a test to assert that won't be reverted in the future?
@jderusse added one, but I can't seem to get your automated checks to pass and they don't seem to be providing any details so if someone can point out what needs to be changed that would be much appreciated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we don't care about the precision loss here.
Updated to make appveyor fail without the patch.
Not sure what fabbot.io is complaining about, so if someone's able to tell me what needs to be changed I can make the change |
I fixed the CS issue @LukeTowers |
Thank you @LukeTowers. |
No problem @nicolas-grekas, thanks for helping push this through! |
Related: #34516, #34508, 9368502, octobercms/october#5410