Skip to content

[HttpFoundation] Drop int return type from parseFilesize() #39633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 19, 2021
Merged

[HttpFoundation] Drop int return type from parseFilesize() #39633

merged 1 commit into from
Jan 19, 2021

Conversation

LukeTowers
Copy link
Contributor

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix octobercms/october#5410
License MIT
Doc PR

Related: #34516, #34508, 9368502, octobercms/october#5410

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.x branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@LukeTowers
Copy link
Contributor Author

@chalasr @yceruto @fabpot please review when able

Copy link
Member

@derrabus derrabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PHP on 32bit is still a thing, apparently. 🤔

@carsonbot carsonbot changed the title Drop int return type from parseFilesize() [HttpFoundation] Drop int return type from parseFilesize() Dec 27, 2020
@LukeTowers
Copy link
Contributor Author

@derrabus apparently. Wouldn't recommend it personally but 🤷

Copy link
Member

@jderusse jderusse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a test to assert that won't be reverted in the future?

@LukeTowers
Copy link
Contributor Author

@jderusse added one, but I can't seem to get your automated checks to pass and they don't seem to be providing any details so if someone can point out what needs to be changed that would be much appreciated.

Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we don't care about the precision loss here.
Updated to make appveyor fail without the patch.

@LukeTowers
Copy link
Contributor Author

Not sure what fabbot.io is complaining about, so if someone's able to tell me what needs to be changed I can make the change

@nicolas-grekas
Copy link
Member

I fixed the CS issue @LukeTowers
I also fixed a related issue in FileType, spotted by the CI on appveyor.

@nicolas-grekas
Copy link
Member

Thank you @LukeTowers.

@nicolas-grekas nicolas-grekas merged commit 3257d4c into symfony:4.4 Jan 19, 2021
@LukeTowers
Copy link
Contributor Author

No problem @nicolas-grekas, thanks for helping push this through!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants