Skip to content

[SecurityBundle] Remove wrong test #39923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 21, 2021
Merged

[SecurityBundle] Remove wrong test #39923

merged 1 commit into from
Jan 21, 2021

Conversation

jderusse
Copy link
Member

@jderusse jderusse commented Jan 21, 2021 •
edited
Loading

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

This tests, asserts that all links to logout are identical, which is wrong and incompatible with BREACH mitigation #39919

@carsonbot carsonbot added this to the 4.4 milestone Jan 21, 2021
@jderusse jderusse removed this from the 4.4 milestone Jan 21, 2021
@carsonbot carsonbot changed the title Remove wrong test [SecurityBundle] Remove wrong test Jan 21, 2021
@nicolas-grekas nicolas-grekas added this to the 4.4 milestone Jan 21, 2021
@jderusse jderusse merged commit 039fe6a into symfony:4.4 Jan 21, 2021
@jderusse jderusse deleted the csrf-test branch January 25, 2021 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@chalasr chalasr chalasr approved these changes

@wouterj wouterj Awaiting requested review from wouterj wouterj is a code owner

Assignees
No one assigned
Labels
Bug SecurityBundle Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@jderusse @nicolas-grekas @chalasr @carsonbot