Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

• Always add tests
• Keep backward compatibility (see https://symfony.com/bc).
• Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
• Features and deprecations must be submitted against the 5.x branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

Please rebase the pull request to the 5.2 branch because it is a bug. By the way, version 5.1 is not longer maintained.

@carsonbot is not right, 5.1 is maintained until the end of this month. Please rebase on top of 5.1 and use it as target branch, thanks.

@OskarStark I agree, but on https://symfony.com/releases, version 5.1 is not maintained (is it normal?)

No it's a bug

cc @xabbuh

Thank you @Kleinast.

(merged on 4.4 as the bug existed there)