Skip to content

[DoctrineBridge] Fix class resolution in Doctrine EventListenerPass #39990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 27, 2021

Conversation

jderusse
Copy link
Member

Q A
Branch? 4.x
Bug fix? yes
New feature? no
Deprecations? no
Tickets fix #
License MIT
Doc PR -

@carsonbot carsonbot added this to the 4.4 milestone Jan 27, 2021
@carsonbot carsonbot changed the title Fix class resolution in Doctrine EventListenerPass [DoctrineBridge] Fix class resolution in Doctrine EventListenerPass Jan 27, 2021
@nicolas-grekas
Copy link
Member

Thank you @jderusse.

@nicolas-grekas nicolas-grekas merged commit 190f089 into symfony:4.4 Jan 27, 2021
@jderusse jderusse deleted the fix-doctrine-resolve branch January 27, 2021 10:42
nicolas-grekas added a commit that referenced this pull request Feb 4, 2021
This PR was merged into the 4.4 branch.

Discussion
----------

[Doctrine] Restore priority for EventSubscribers

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | fix #40031
| License       | MIT
| Doc PR        | -

Since #39990, lazy subscribers are called AFTER listeners (which is the opposite of previous implementation).
This PR restore the previous behavior.

Note: ordered subscribers is implemented in #39978 but is considered as a new feature.

Commits
-------

94eac1b Restore priority for eventSubscribers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants