Speedup psalm #40311
Merged
Speedup psalm #40311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
670d782 to
04dd1a2
Compare
bendavies
reviewed
Feb 25, 2021
bendavies
reviewed
Feb 25, 2021
d42c38a to
4b09d92
Compare
1d40d61 to
ec00d08
Compare
ec00d08 to
3fb74ab
Compare
|
Well done! |
stof
reviewed
Feb 26, 2021
| path: pr/.github/psalm/cache/ | ||
| key: psalm-${{ github.base_ref }} | ||
| restore-keys: psalm- | ||
| git checkout -m ${{ github.base_ref }} |
There was a problem hiding this comment.
a simpler solution might be to move the checkout PR step after the generation of the baseline based on base
There was a problem hiding this comment.
not really: that would miss installing the deps added to the PR, if any
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My try at #40310