[Console] Deprecate Helper::strlen() for width() and length() #40695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nyholm
commented
Apr 3, 2021
There was a problem hiding this comment.
There are a lot of changes in this PR, but only the two lines I've marked below is significant, the others are just renaming.
What I fail to understand is that in the Table, it feels like it should be "width" instead of "length". But "length" is the one working".
| @@ -513,7 +513,7 @@ private static function initPlaceholderFormatters(): array | |||
| $completeBars = $bar->getBarOffset(); | |||
| $display = str_repeat($bar->getBarCharacter(), $completeBars); | |||
| if ($completeBars < $bar->getBarWidth()) { | |||
| $emptyBars = $bar->getBarWidth() - $completeBars - Helper::strlenWithoutDecoration($output->getFormatter(), $bar->getProgressCharacter()); | |||
| $emptyBars = $bar->getBarWidth() - $completeBars - Helper::strlengthWithoutDecoration($output->getFormatter(), $bar->getProgressCharacter()); | |||
| @@ -511,7 +511,8 @@ private function renderCell(array $row, int $column, string $cellFormat): string | |||
| return sprintf($style->getBorderFormat(), str_repeat($style->getBorderChars()[2], $width)); | |||
| } | |||
|
|
|||
| $width += Helper::strlen($cell) - Helper::strlenWithoutDecoration($this->output->getFormatter(), $cell); | |||
| $x = 2; | |||
| $width += Helper::strlength($cell) - Helper::strlengthWithoutDecoration($this->output->getFormatter(), $cell); | |||
27228d3 to
7484158
Compare
|
We cannot deprecate something in 5.2 as it's a maintenance branch, it should be done on 5.x. |
|
Thank you. I was hesitant about this. Are we okey with reverting #40524, adding that PR as a feature to 5.x and then merge this PR in 5.x? |
7484158 to
c9c3c01
Compare
This was referenced Apr 3, 2021
fabpot
added a commit
that referenced
this pull request
Apr 8, 2021
…, grasmash) This PR was merged into the 5.2 branch. Discussion ---------- [Console] Add Helper::width() and Helper::length() | Q | A | ------------- | --- | Branch? | 5.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Close #40697 Fix #40634, fix #40635 | License | MIT | Doc PR | This PR will add add a Helper::strwidth() and a Helper::strlength(). Same with with the Helper::strlenWithoutDecoration(). It does not deprecate anything. That is done in #40695 With this PR we dont have to revert the emoji issue (ie close #40697) FYI @grasmash, I used your tests from #40635 Commits ------- d9ea4c5 Add test. dc02ab3 [Console] Add Helper::strwidth() and Helper::strlength()
fabpot
requested changes
Apr 8, 2021
c9c3c01 to
5679e99
Compare
fabpot
reviewed
Apr 8, 2021
fabpot
reviewed
Apr 8, 2021
5e65d3b to
b883112
Compare
chalasr
reviewed
Apr 8, 2021
chalasr
approved these changes
Apr 8, 2021
fabpot
approved these changes
Apr 9, 2021
6ca1bf6 to
3c24aa9
Compare
|
Thank you @Nyholm. |
|
Thank you for merging |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will deprecated
Helper::strlen()since it is actually calculating the width. I remove the@internalonHelper::width()and aHelper::length(). I will also deprecateHelper::strlenWithoutDecoration()because you should useHelper::removeDecoration()instead.