[FrameworkBundle] Add argument KernelInterface to BuildDebugContainerTrait::getContainerBuilder() #40810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yceruto
approved these changes
Apr 13, 2021
src/Symfony/Bundle/FrameworkBundle/Command/RouterDebugCommand.php
Outdated
Show resolved
Hide resolved
a02bca9 to
b1e36f1
Compare
OskarStark
approved these changes
Apr 14, 2021
|
Thank you Tobias. |
1f27d65 to
0e9652a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comes from a suggestion by @yceruto #40804 (comment)
This change will make the trait usable outside the
Commandnamespace. I did not find a better namespace to move the trait to though.. This patch will help #40804The trait is internal so the change is okey.