Skip to content

[PropertyInfo] PhpDocExtractor: Handle "true" and "false" property types #40943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

maciejzgadzaj
Copy link

Q A
Branch? 5.2
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #40942
License MIT
Doc PR

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.x branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

Copy link
Member

@dunglas dunglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test please?

@maciejzgadzaj maciejzgadzaj force-pushed the phpdocextractor-true-false-property-types branch from 5ae54d2 to b7658aa Compare April 25, 2021 09:56
@maciejzgadzaj
Copy link
Author

Sure thing, wanted to make sure that this is the correct direction first.

Tests added.

@carsonbot carsonbot changed the title PhpDocExtractor: Handle "true" and "false" property types [PropertyInfo] PhpDocExtractor: Handle "true" and "false" property types May 7, 2021
@nicolas-grekas
Copy link
Member

Thank you @maciejzgadzaj.

@nicolas-grekas nicolas-grekas merged commit 72cc666 into symfony:5.2 May 7, 2021
This was referenced May 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants