Skip to content

[HttpFoundation] Fixes for PHP 8.1 deprecations #40964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 27, 2021
Merged

[HttpFoundation] Fixes for PHP 8.1 deprecations #40964

merged 1 commit into from
Apr 27, 2021

Conversation

jrmajor
Copy link
Contributor

@jrmajor jrmajor commented Apr 27, 2021

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Fixes passing null to non-nullable arguments.

@carsonbot carsonbot added this to the 4.4 milestone Apr 27, 2021
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.x branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

jrmajor
jrmajor commented Apr 27, 2021
View reviewed changes
src/Symfony/Component/HttpFoundation/Tests/RequestTest.php
[[null, [null, 'unexistent-mime-type']]],
[[null, ['unexistent-mime-type']]],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request::getFormat() does not accept null:

symfony/src/Symfony/Component/HttpFoundation/Request.php

Lines 1308 to 1315 in b306bdb

/**
* Gets the format associated with the mime type.
*
* @param string $mimeType The associated mime type
*
* @return string|null The format (null if not found)
*/
public function getFormat($mimeType)

@jrmajor jrmajor force-pushed the php81/http-foundation branch from 1ebc4a3 to 10be072 Compare April 27, 2021 16:57
@derrabus
Copy link
Member

Thank you @jrmajor.

@derrabus derrabus merged commit a88c7fa into symfony:4.4 Apr 27, 2021
@jrmajor jrmajor deleted the php81/http-foundation branch April 27, 2021 18:18
This was referenced May 1, 2021
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof approved these changes

@derrabus derrabus derrabus approved these changes

Assignees
No one assigned
Labels
Bug HttpFoundation Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@jrmajor @carsonbot @derrabus @stof