Skip to content

[VarExporter] Add support of PHP enumerations #41072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 6, 2021
Merged

[VarExporter] Add support of PHP enumerations #41072

merged 1 commit into from
May 6, 2021

Conversation

alexandre-daubois
Copy link
Member

@alexandre-daubois alexandre-daubois commented May 2, 2021 •
edited by nicolas-grekas
Loading

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #40237
License MIT
Doc PR none

@alexandre-daubois alexandre-daubois force-pushed the feat-var-exporter-enum-support branch from 78e2441 to 809cfc3 Compare May 2, 2021 15:52
nicolas-grekas
nicolas-grekas reviewed May 2, 2021
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't expect this patch to be that simple, thanks for opening :)
Can you please rebase for 4.4? We consider support for newer PHP versions as a bug fix.

@nicolas-grekas nicolas-grekas added this to the 4.4 milestone May 2, 2021
@nicolas-grekas nicolas-grekas added Bug and removed Feature labels May 2, 2021
@alexandre-daubois alexandre-daubois force-pushed the feat-var-exporter-enum-support branch 2 times, most recently from 3a4c27c to 9cf44c2 Compare May 3, 2021 11:10
@alexandre-daubois alexandre-daubois force-pushed the feat-var-exporter-enum-support branch from 9cf44c2 to f204ccb Compare May 3, 2021 11:29
@alexandre-daubois alexandre-daubois changed the base branch from 5.x to 4.4 May 3, 2021 11:29
@alexandre-daubois alexandre-daubois force-pushed the feat-var-exporter-enum-support branch 2 times, most recently from d444cd1 to e4f0c5a Compare May 3, 2021 12:49
@nicolas-grekas nicolas-grekas changed the title [VarExporter] Add support of PHP 8.1 enumerations [VarExporter] Add support of PHP enumerations May 6, 2021
@nicolas-grekas nicolas-grekas force-pushed the feat-var-exporter-enum-support branch from e4f0c5a to 4b0f299 Compare May 6, 2021 19:18
@nicolas-grekas
Copy link
Member

Thank you @alexandre-daubois.

@nicolas-grekas nicolas-grekas merged commit e51e651 into symfony:4.4 May 6, 2021
@alexandre-daubois alexandre-daubois deleted the feat-var-exporter-enum-support branch May 7, 2021 06:53
This was referenced May 9, 2021
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark left review comments

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Bug Status: Reviewed VarExporter
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

[VarExporter] add support for Enums on PHP 8.1
4 participants
@alexandre-daubois @nicolas-grekas @OskarStark @carsonbot