Skip to content

[ErrorHandler] Skip "same vendor" @method deprecations for Symfony\* classes unless symfony/symfony is being tested #41075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2021
Merged

[ErrorHandler] Skip "same vendor" @method deprecations for Symfony\* classes unless symfony/symfony is being tested #41075

merged 1 commit into from
May 3, 2021

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets ref #40975 #40996 #40893
License MIT
Doc PR

Replaces #41001

@nicolas-grekas nicolas-grekas added this to the 4.4 milestone May 2, 2021
@nicolas-grekas nicolas-grekas requested a review from yceruto as a code owner May 2, 2021 17:37
@nicolas-grekas nicolas-grekas mentioned this pull request May 2, 2021
Closed
@nicolas-grekas nicolas-grekas changed the title [ErrorHandler] Skip "same vendor" @method deprecations unless symfony/symfony is being tested [ErrorHandler] Skip @method deprecations for symfony/* packages, but for symfony/symfony May 2, 2021
@nicolas-grekas nicolas-grekas force-pushed the eh-fix branch 3 times, most recently from 160f0b8 to e92b387 Compare May 2, 2021 17:44
@nicolas-grekas nicolas-grekas changed the title [ErrorHandler] Skip @method deprecations for symfony/* packages, but for symfony/symfony [ErrorHandler] Skip "same vendor" @method deprecations for Symfony\* classes unless symfony/symfony is being used May 2, 2021
@nicolas-grekas nicolas-grekas changed the title [ErrorHandler] Skip "same vendor" @method deprecations for Symfony\* classes unless symfony/symfony is being used [ErrorHandler] Skip "same vendor" @method deprecations for Symfony\* classes unless symfony/symfony is being used May 2, 2021
@nicolas-grekas nicolas-grekas force-pushed the eh-fix branch 3 times, most recently from afac099 to 7e82b57 Compare May 2, 2021 17:53
@nicolas-grekas nicolas-grekas changed the title [ErrorHandler] Skip "same vendor" @method deprecations for Symfony\* classes unless symfony/symfony is being used [ErrorHandler] Skip "same vendor" @method deprecations for Symfony\* classes unless symfony/symfony is being tested May 2, 2021
@nicolas-grekas
[ErrorHandler] Skip "same vendor" @method deprecations for `Symfony…
7a1a910 
…\*` classes unless symfony/symfony is being tested
@derrabus
Copy link
Member

derrabus commented May 3, 2021

Thank you Nicolas.

@derrabus derrabus merged commit 88dcf52 into symfony:4.4 May 3, 2021
@chalasr chalasr mentioned this pull request May 4, 2021
Closed
@nicolas-grekas nicolas-grekas deleted the eh-fix branch May 6, 2021 19:20
@fabpot fabpot mentioned this pull request May 9, 2021
Merged
@alanpoulain alanpoulain mentioned this pull request May 10, 2021
Closed
This was referenced May 12, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derrabus derrabus derrabus approved these changes

@yceruto yceruto yceruto approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Bug ErrorHandler Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
5 participants
@nicolas-grekas @derrabus @yceruto @chalasr @carsonbot