Skip to content

Fix return type in isAllowedProperty method on ReflectionExtractor class #41104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Tomanhez
Copy link
Contributor

@Tomanhez Tomanhez commented May 4, 2021

Q A
Branch? 5.2
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #41103
License MIT
Doc PR symfony/symfony-docs#...

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.x branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

Copy link
Member

@derrabus derrabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't use boolval() in this codebase. Please apply the fix suggested by fabbot.

Can you also please add a failing test for your issue?

@derrabus derrabus added this to the 5.2 milestone May 4, 2021
@derrabus
Copy link
Member

derrabus commented May 4, 2021

You opened a bugfix for 5.2, but you have created a PR for the 5.x branch. Can you please rebase and retarget your PR?

@Tomanhez Tomanhez force-pushed the fix-reflection-extractor-is-allowed-property branch from 4e2b404 to 8c0e8f7 Compare May 4, 2021 13:54
@Tomanhez Tomanhez changed the base branch from 5.x to 5.2 May 4, 2021 13:55
@Tomanhez
Copy link
Contributor Author

Tomanhez commented May 4, 2021

@derrabus I changed boolval for (bool) but with additional brackets and its work properly.

@fabpot
Copy link
Member

fabpot commented May 6, 2021

Thank you @Tomanhez.

@fabpot fabpot merged commit 3f57255 into symfony:5.2 May 6, 2021
This was referenced May 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Method isAllowedProperty on ReflectionExtractor class can return int type
4 participants