-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
Fix return type in isAllowedProperty method on ReflectionExtractor class #41104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix return type in isAllowedProperty method on ReflectionExtractor class #41104
Conversation
Tomanhez
commented
May 4, 2021
•
edited
Loading
edited
Q | A |
---|---|
Branch? | 5.2 |
Bug fix? | yes |
New feature? | no |
Deprecations? | no |
Tickets | Fix #41103 |
License | MIT |
Doc PR | symfony/symfony-docs#... |
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't use boolval()
in this codebase. Please apply the fix suggested by fabbot.
Can you also please add a failing test for your issue?
You opened a bugfix for 5.2, but you have created a PR for the 5.x branch. Can you please rebase and retarget your PR? |
4e2b404
to
8c0e8f7
Compare
@derrabus I changed |
Thank you @Tomanhez. |