Skip to content

[DependencyInjection][ProxyManagerBridge] Don't call class_exists() on null #41233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2021
Merged

[DependencyInjection][ProxyManagerBridge] Don't call class_exists() on null #41233

merged 1 commit into from
May 15, 2021

Conversation

derrabus
Copy link
Member

@derrabus derrabus commented May 14, 2021 •
edited
Loading

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets N/A
License MIT
Doc PR N/A

PHP 8.1 complains if we pass null to class_exists() or interface_exists():

class_exists(): Passing null to parameter #1 ($class) of type string is deprecated

@carsonbot carsonbot added this to the 4.4 milestone May 14, 2021
@carsonbot carsonbot changed the title Don't call class_exists() on null [DependencyInjection][ProxyManagerBridge] Don't call class_exists() on null May 14, 2021
@nicolas-grekas
Copy link
Member

Thank you @derrabus.

@nicolas-grekas nicolas-grekas merged commit 9e12a38 into symfony:4.4 May 15, 2021
@derrabus derrabus deleted the bugfix/class-exists-null branch May 15, 2021 08:20
This was referenced May 19, 2021
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jderusse jderusse jderusse approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Bug DependencyInjection ProxyManagerBridge Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
5 participants
@derrabus @nicolas-grekas @jderusse @chalasr @carsonbot