Fixed deprecation warnings about passing null as parameter #41240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5866fb1 to
29df695
Compare
src/Symfony/Component/DependencyInjection/Compiler/ResolveBindingsPass.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/CssSelector/XPath/Extension/NodeExtension.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/DependencyInjection/Compiler/CheckTypeDeclarationsPass.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/DependencyInjection/Compiler/RegisterServiceSubscribersPass.php
Outdated
Show resolved
Hide resolved
The Fabbot patch would break the PHP 5 compatibility of the PhpUnitBridge. |
29df695 to
8e8adc3
Compare
8e8adc3 to
7d9bdf5
Compare
nicolas-grekas
approved these changes
May 16, 2021
fabpot
approved these changes
May 16, 2021
|
Thank you @derrabus. |
This was referenced May 19, 2021
Merged
Merged
Merged
nicolas-grekas
added a commit
that referenced
this pull request
May 21, 2021
This PR was merged into the 5.2 branch. Discussion ---------- Fix PHP 8.1 deprecations | Q | A | ------------- | --- | Branch? | 5.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | N/A | License | MIT | Doc PR | N/A Follow-up of #41240 on the 5.2 branch Commits ------- fb99f93 Fix PHP 8.1 deprecations
nicolas-grekas
added a commit
that referenced
this pull request
Jun 6, 2021
This PR was merged into the 4.4 branch. Discussion ---------- [Translation] Don't pass null to strtoupper() | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Part of #41552 | License | MIT | Doc PR | N/A This error popped up on 5.3, but not on 4.4. That's why I missed it when fixing the other occurrence with #41240. Commits ------- 3c8cf9a [Translation] Don't pass null to strtoupper()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various built-in PHP functions will trigger a deprecation warning if
nullis passed as parameter. This PR attempts to fix all warnings that our test suite currently picks up.