Skip to content

[Console] fix managing signals when commands are lazy loaded #41680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 11, 2021
Merged

[Console] fix managing signals when commands are lazy loaded #41680

merged 1 commit into from
Jun 11, 2021

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 5.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #41583
License MIT
Doc PR -

@nicolas-grekas nicolas-grekas requested a review from chalasr as a code owner June 11, 2021 13:45
@carsonbot carsonbot added this to the 5.3 milestone Jun 11, 2021
chalasr
chalasr approved these changes Jun 11, 2021
View reviewed changes
Copy link
Member

@chalasr chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 fabbot failure is a false positive

@chalasr
Copy link
Member

chalasr commented Jun 11, 2021

Thank you @nicolas-grekas.

@chalasr chalasr merged commit b8d824e into symfony:5.3 Jun 11, 2021
@nicolas-grekas nicolas-grekas deleted the console-lazy-signalable branch June 12, 2021 09:26
@fabpot fabpot mentioned this pull request Jun 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Bug Console Status: Reviewed
Projects
None yet
Milestone
5.3
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolas-grekas @chalasr @carsonbot