[Security] Fix invalid cookie when migrating to new Security #41744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40cc4d5 to
aa68e2c
Compare
wouterj
approved these changes
Jun 18, 2021
fabpot
approved these changes
Jun 18, 2021
|
Thank you @jderusse. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the new Security System, the method
RememberMeDetails::fromRawCookieexpects to get a cookie made of 4 parts.This is not the case when the cookie has been generated by a
PersistentTokenBasedRememberMeServices.This is an issue when migrating an application to the new Security System, old cookie lead to 500 errors.
This PR fix the issue by throwing gracefully a
AuthenticationException. Handled by the authenticator.