[Security] Deprecate "always authenticate" and "exception on no token" #41965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
wouterj
commented
Jul 3, 2021
| Q | A |
|---|---|
| Branch? | 5.4 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | yes |
| Tickets | Ref #41613 |
| License | MIT |
| Doc PR | n/a |
8e434bf to
d4e33ca
Compare
chalasr
reviewed
Jul 4, 2021
src/Symfony/Component/Security/Core/Authorization/AuthorizationChecker.php
Show resolved
Hide resolved
chalasr
reviewed
Jul 4, 2021
src/Symfony/Bundle/SecurityBundle/DependencyInjection/MainConfiguration.php
Outdated
Show resolved
Hide resolved
d4e33ca to
4bba287
Compare
chalasr
approved these changes
Jul 4, 2021
| @@ -34,6 +34,13 @@ class AuthorizationChecker implements AuthorizationCheckerInterface | |||
|
|
|||
| public function __construct(TokenStorageInterface $tokenStorage, AuthenticationManagerInterface $authenticationManager, AccessDecisionManagerInterface $accessDecisionManager, bool $alwaysAuthenticate = false, bool $exceptionOnNoToken = true) | |||
| { | |||
| if (false !== $alwaysAuthenticate) { | |||
| trigger_deprecation('symfony/security-core', '5.4', 'Not setting the 4th argument of "%s" to "false" is deprecated.', __METHOD__); | |||
There was a problem hiding this comment.
(minor) we might prefer talking about arguments names over positions in deprecation messages, see e.g. 8e3058d
fabpot
approved these changes
Jul 8, 2021
|
Thank you @wouterj. |
This was referenced Nov 5, 2021
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.