Add return types to bridges #42501
Merged
Add return types to bridges #42501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b4cec41 to
1ea501d
Compare
|
🟢 |
derrabus
reviewed
Aug 12, 2021
Comment on lines
40
to
41
| * | ||
| * @return self|null |
There was a problem hiding this comment.
Suggested change
| * | |
| * @return self|null |
There was a problem hiding this comment.
I'll delegate all similar changes to php-cs-fixer when it can do it.
There was a problem hiding this comment.
Okay. It's just that you've already removed the return annotations from other methods in this PR, but not here.
There was a problem hiding this comment.
yep, looks like something to fix for php-cs-fixer when union types are used
derrabus
approved these changes
Aug 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #42496