Skip to content

Add return types - batch 6/n #42511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 16, 2021
Merged

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 6.0
Bug fix? no
New feature? yes
Deprecations? no
Tickets #40154
License MIT
Doc PR -

Extracted from #42496

Not all possible return types are patched for the attached components, to save breaking BC cross-components, for now at least.

@nicolas-grekas
Copy link
Member Author

Help wanted to fix psalm failures

@carsonbot
Copy link

Hey!

I think @fancyweb has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

@Tobion
Copy link
Contributor

Tobion commented Aug 13, 2021

Help wanted to fix psalm failures

#42537 should fix those

nicolas-grekas added a commit that referenced this pull request Aug 16, 2021
This PR was merged into the 5.4 branch.

Discussion
----------

[Form] Fix return types in form builder

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       |
| License       | MIT
| Doc PR        |

Fix return types incompatibilities found by psalm in #42511

> Error: The declared return type 'Symfony\Component\EventDispatcher\EventDispatcherInterface' for Symfony\Component\Form\ButtonBuilder::getEventDispatcher is not nullable, but 'null' contains null (see https://psalm.dev/144)
Error: The declared return type 'string' for Symfony\Component\Form\ButtonBuilder::getAction is not nullable, but 'null' contains null (see https://psalm.dev/144)
Error: The declared return type 'string' for Symfony\Component\Form\ButtonBuilder::getMethod is not nullable, but 'null' contains null (see https://psalm.dev/144)
Error: The declared return type 'Symfony\Component\Form\RequestHandlerInterface' for Symfony\Component\Form\ButtonBuilder::getRequestHandler is not nullable, but 'null' contains null (see https://psalm.dev/144)
Error: The declared return type 'Symfony\Component\Form\FormFactoryInterface' for Symfony\Component\Form\FormConfigBuilder::getFormFactory is not nullable, but 'Symfony\Component\Form\FormFactoryInterface|null' contains null (see https://psalm.dev/144)
Error: The declared return type 'string' for Symfony\Component\Form\FormConfigBuilder::getAction is not nullable, but 'null|string' contains null (see https://psalm.dev/144)

Commits
-------

ea606ea [Form] Fix return types in form builder
@nicolas-grekas nicolas-grekas force-pushed the return-types-6 branch 6 times, most recently from dcfdae8 to f7403f2 Compare August 16, 2021 15:39
@nicolas-grekas nicolas-grekas merged commit 2aebc94 into symfony:6.0 Aug 16, 2021
@nicolas-grekas nicolas-grekas deleted the return-types-6 branch August 16, 2021 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants