Skip to content

Make test.session.listener compatible with SF 6.0 SessionListener #42906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 6, 2021
Merged

Make test.session.listener compatible with SF 6.0 SessionListener #42906

merged 1 commit into from
Sep 6, 2021

Conversation

jderusse
Copy link
Member

@jderusse jderusse commented Sep 6, 2021

Q A
Branch? 5.4
Bug fix? no
New feature? yes
Deprecations? no
Tickets -
License MIT
Doc PR -

Fix flipped tests for #41321

In Symfony 6.0, the session_listener does not use session service anymore, it needs a session_factory instead.

note: the session_listener service is properly configured:

symfony/src/Symfony/Bundle/FrameworkBundle/Resources/config/session.php

Lines 146 to 150 in 0d61de7

->set('session_listener', SessionListener::class)
->args([
service_locator([
'session_factory' => service('session.factory')->ignoreOnInvalid(),
'session' => service('.session.do-not-use')->ignoreOnInvalid(),

@nicolas-grekas nicolas-grekas added this to the 5.4 milestone Sep 6, 2021
@nicolas-grekas
Copy link
Member

Thank you @jderusse.

@nicolas-grekas nicolas-grekas merged commit 03d673c into symfony:5.4 Sep 6, 2021
@jderusse jderusse deleted the session-fc branch September 7, 2021 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derrabus derrabus derrabus approved these changes

Assignees
No one assigned
Labels
Feature Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
4 participants
@jderusse @nicolas-grekas @derrabus @carsonbot