Skip to content

[Mailer] Adding support for TagHeader and MetadataHeader to the Sendgrid API transport #43018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 15, 2021
Merged

[Mailer] Adding support for TagHeader and MetadataHeader to the Sendgrid API transport #43018

merged 1 commit into from
Sep 15, 2021

Conversation

gnito-org
Copy link
Contributor

Q A
Branch? 5.4
Bug fix? no
New feature? yes
Deprecations? no
Tickets None
License MIT
Doc PR symfony/symfony-docs#15816

I added support for tags and metadata to the Mailer Sendgrid API transport, in response to this discussion: #42481

The relevant Sendgrid API documentation is located at:

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@gnito-org
Copy link
Contributor Author

I don't think the two failing tests were caused by this pull request. The 8.0, low deps test complains about Error: Class "Symfony\Component\Mailer\Header\TagHeader" not found, which makes no sense. The PHPUnit tests pass on my local machine with PHP 8.

@gnito-org
Copy link
Contributor Author

@fabpot Thank you for your suggested changes. I coded it that way because I thought I was following Symfony standards by replicating the way that the Mailchimp, Postmark, and Sendinblue API transports were coded.

@gnito-org gnito-org requested a review from fabpot September 15, 2021 11:03
@fabpot
Copy link
Member

fabpot commented Sep 15, 2021

Thank you @gnito-org.

@fabpot fabpot merged commit c03d45a into symfony:5.4 Sep 15, 2021
@chalasr chalasr mentioned this pull request Sep 16, 2021
Merged
chalasr added a commit that referenced this pull request Sep 16, 2021
@chalasr
minor #43053 [Mailer] [Sendgrid] Fix test (chalasr)
7167324 
This PR was merged into the 5.4 branch.

Discussion
----------

[Mailer] [Sendgrid] Fix test

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

low-deps build is broken after #43018 because it uses symfony/mailer 4.4.x while `TagHeader` is 5.x only.

Commits
-------

375e95a [Mailer][Sendgrid] Fix test
This was referenced Nov 5, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark left review comments

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Feature Mailer Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gnito-org @carsonbot @fabpot @OskarStark