Skip to content

[SecurityBundle] Fixed LogicException message of FirewallAwareTrait #43146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 26, 2021
Merged

[SecurityBundle] Fixed LogicException message of FirewallAwareTrait #43146

merged 1 commit into from
Sep 26, 2021

Conversation

fkropfhamer
Copy link
Contributor

Q A
Branch? 5.4 for features / 4.4 or 5.3 for bug fixes
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #43145
License MIT
Doc PR symfony/symfony-docs#...

@carsonbot carsonbot added this to the 5.4 milestone Sep 23, 2021
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@derrabus derrabus modified the milestones: 5.4, 5.3 Sep 23, 2021
@carsonbot carsonbot changed the title Fixed LogicException message of FirewallAwareTrait. [SecurityBundle] Fixed LogicException message of FirewallAwareTrait. Sep 23, 2021
@derrabus derrabus changed the title [SecurityBundle] Fixed LogicException message of FirewallAwareTrait. [SecurityBundle] Fixed LogicException message of FirewallAwareTrait Sep 23, 2021
@derrabus
Copy link
Member

The change looks correct from my perspective. Would you be able to provide a failing test for your issue?

@fkropfhamer
Copy link
Contributor Author

@derrabus Do you mean a unit test?

@derrabus
Copy link
Member

Yes. A unit test that fails without and passes with your change.

@fkropfhamer
Copy link
Contributor Author

Ok, I will try!

nicolas-grekas
nicolas-grekas reviewed Sep 24, 2021
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we prefer using real instances instead of mocks when possible
can you please have a look at your test with this in mind?
(we can use mocks when creating a real instance is too complex of course)

@fkropfhamer fkropfhamer force-pushed the fix/firewallawairetrait-error branch from 08117b0 to 2e2b107 Compare September 24, 2021 19:28
@fabpot fabpot changed the base branch from 5.4 to 5.3 September 26, 2021 16:33
@fabpot fabpot requested a review from yceruto as a code owner September 26, 2021 16:33
@fabpot fabpot force-pushed the fix/firewallawairetrait-error branch from 2e2b107 to d93da59 Compare September 26, 2021 16:33
@fabpot
Copy link
Member

fabpot commented Sep 26, 2021

Thank you @fkropfhamer.

@fabpot fabpot merged commit 4a54875 into symfony:5.3 Sep 26, 2021
@fabpot fabpot mentioned this pull request Sep 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@fabpot fabpot fabpot approved these changes

@derrabus derrabus derrabus approved these changes

@chalasr chalasr chalasr approved these changes

@wouterj wouterj Awaiting requested review from wouterj wouterj is a code owner

@dunglas dunglas Awaiting requested review from dunglas

@jderusse jderusse Awaiting requested review from jderusse

@lyrixx lyrixx Awaiting requested review from lyrixx

@OskarStark OskarStark Awaiting requested review from OskarStark

@sroze sroze Awaiting requested review from sroze

@xabbuh xabbuh Awaiting requested review from xabbuh

@yceruto yceruto Awaiting requested review from yceruto

Assignees
No one assigned
Labels
Bug SecurityBundle Status: Needs Review
Projects
None yet
Milestone
5.3
Development

Successfully merging this pull request may close these issues.

[Security] FirewallAwareTrait throws Critical Error instead of throwing Exception
6 participants
@fkropfhamer @carsonbot @derrabus @fabpot @nicolas-grekas @chalasr