Skip to content

[Ldap] Fix resource type checks & docblocks on PHP 8.1 #43179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2021

Conversation

chalasr
Copy link
Member

@chalasr chalasr commented Sep 26, 2021

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

From https://www.php.net/manual/en/migration81.incompatible.php:

Several resources have been migrated to objects. Return value checks using is_resource() should be replaced with checks for false.
The LDAP functions now accept and return, respectively, LDAP\ResultEntry objects instead of ldap result entry resources.
The LDAP functions now accept and return, respectively, LDAP\Connection objects instead of ldap link resources.
The LDAP functions now accept and return, respectively, LDAP\Result objects instead of ldap result resources.
The LDAP functions now accept and return, respectively, LDAP\ResultEntry objects instead of ldap result entry resources.

See also php/php-src#6770

@carsonbot carsonbot added this to the 4.4 milestone Sep 26, 2021
@carsonbot carsonbot changed the title [LDAP] Fix resource type checks & docblocks on PHP 8.1 [Ldap] Fix resource type checks & docblocks on PHP 8.1 Sep 26, 2021
@chalasr chalasr force-pushed the ldap-resource-objects branch from 5acaa2f to 5d5995e Compare September 26, 2021 12:09
@chalasr chalasr force-pushed the ldap-resource-objects branch from 5d5995e to 2c0f7e0 Compare September 26, 2021 15:26
@fabpot
Copy link
Member

fabpot commented Sep 26, 2021

Thank you @chalasr.

@fabpot fabpot merged commit 3c2c716 into symfony:4.4 Sep 26, 2021
@chalasr chalasr deleted the ldap-resource-objects branch September 26, 2021 16:30
@derrabus
Copy link
Member

Linking to #41552. 🙃

This was referenced Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants