Skip to content

[HttpClient] improve curl error message when possible #43210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 29, 2021

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 5.4
Bug fix? no
New feature? no
Deprecations? no
Tickets Fix #37666
License MIT
Doc PR -

Fix #37666, improves #31586

@stof
Copy link
Member

stof commented Sep 28, 2021

@nicolas-grekas what about my suggestion in #37666 (comment) ?

@nicolas-grekas
Copy link
Member Author

Here are some examples if we concat both messages:

That's why I didn't do it here as it looks like this would put duplicates in the message...

@nicolas-grekas nicolas-grekas merged commit c8879b2 into symfony:5.4 Sep 29, 2021
@nicolas-grekas nicolas-grekas deleted the hc-curle branch September 29, 2021 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[HttpClient] Improv curl error message
3 participants