Skip to content

[Console] feat: add completion for CompletionCommand "shell" argument #43615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2021
Merged

[Console] feat: add completion for CompletionCommand "shell" argument #43615

merged 1 commit into from
Oct 20, 2021

Conversation

dkarlovi
Copy link
Contributor

Q A
Branch? 5.4
Bug fix? no
New feature? yes
Deprecations? no
Tickets #43594
License MIT
Doc PR N/A

@dkarlovi dkarlovi requested a review from chalasr as a code owner October 20, 2021 15:10
@carsonbot carsonbot added this to the 5.4 milestone Oct 20, 2021
@carsonbot
Copy link

It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you.

Cheers!

Carsonbot

@dkarlovi
Copy link
Contributor Author

Eh, I don't have "Allow edit from maintainers" anywhere, GH must have moved it somewhere secret.

@wouterj
Copy link
Member

wouterj commented Oct 20, 2021

Thank you @dkarlovi!

@wouterj wouterj merged commit ec34dd5 into symfony:5.4 Oct 20, 2021
@carsonbot carsonbot changed the title feat: add completion for CompletionCommand "shell" argument [Console] feat: add completion for CompletionCommand "shell" argument Oct 20, 2021
@dkarlovi dkarlovi deleted the feat/completion-dump-completion branch October 20, 2021 16:53
@wouterj wouterj mentioned this pull request Oct 22, 2021
Closed
54 tasks
This was referenced Nov 5, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

Assignees
No one assigned
Labels
Console Feature Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
5 participants
@dkarlovi @carsonbot @wouterj @fabpot @derrabus