[Uid] Allow use autocompletion #43639
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
reviewed
Oct 21, 2021
| if (\in_array($formatOption, $this->getAvailableFormatOptions())) { | ||
| $format = 'to'.ucfirst($formatOption); | ||
| } else { | ||
| $io->error(sprintf('Invalid format "%s", did you mean "base32", "base58" or "rfc4122"?', $input->getOption('format'))); |
There was a problem hiding this comment.
The error message could use the list.
There was a problem hiding this comment.
Thanks, I made PR #43849
54 tasks
fabpot
approved these changes
Oct 22, 2021
|
Thank you @StaffNowa. |
Closed
| } | ||
| } | ||
|
|
||
| private function getAvailableFormatOptions(): array |
There was a problem hiding this comment.
replaced by a const in d0f6b98
This was referenced Nov 5, 2021
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Bash completion for following commands:
ulid:generate
uuid-genereate