Skip to content

Allow autodetecting mapping type for any object #43917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2021
Merged

Allow autodetecting mapping type for any object #43917

merged 1 commit into from
Nov 19, 2021

Conversation

franmomu
Copy link
Contributor

@franmomu franmomu commented Nov 3, 2021

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

This PR would allow to auto detect the mapping type for Documents or other types

@carsonbot carsonbot added this to the 5.4 milestone Nov 3, 2021
@franmomu franmomu changed the title Allow autodetecting mapping type for any object [DoctrineBridge] Allow autodetecting mapping type for any object Nov 3, 2021
@fabpot fabpot modified the milestones: 5.4, 6.1 Nov 10, 2021
@franmomu
Copy link
Contributor Author

IMHO this should be targeted to 5.4. The reason is that in 5.4, since #43754, using DoctrineMongoDBBundle and PHP >= 8 it will set attribute as default mapping and will fail having documents with annotations.

@carsonbot carsonbot changed the title [DoctrineBridge] Allow autodetecting mapping type for any object Allow autodetecting mapping type for any object Nov 18, 2021
@nicolas-grekas nicolas-grekas modified the milestones: 6.1, 5.4 Nov 19, 2021
@fabpot
Copy link
Member

fabpot commented Nov 19, 2021

Thank you @franmomu.

@fabpot fabpot merged commit 5ae859d into symfony:5.4 Nov 19, 2021
This was referenced Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants