[Console] Open CompleteCommand for custom outputs #43923
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
approved these changes
Nov 4, 2021
fabpot
requested changes
Nov 4, 2021
|
You should add a test, right? |
stof
reviewed
Nov 4, 2021
bd2cad0 to
d3e4574
Compare
|
Thanks for the reviews. All should be fixed now. status: needs review |
fabpot
approved these changes
Nov 4, 2021
|
Can you fix the tests? The output has changed a bit. |
d3e4574 to
1f58312
Compare
|
Ooh, not again 😣 . Should be green now |
|
Thank you @wouterj. |
|
@wouterj as we now make the CompletionOutputInterface an extension point where third-party code can register their own implementation, I think we need to add the constructor with no argument in the interface, to enforce that signature (as the instantiation is done in the CompleteCommand |
This was referenced Nov 5, 2021
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having this feature in 5.4 is especially great, as it will allow Composer 2.2 to use this feature as well.
If we in the future add fish or zsh support, it would be very cool if these can be "backported" by Composer. Keeping the
$completionOutputsproperty closed would permit this, while this little change opens up adding custom output supports outside the Symfony source code.