Skip to content

[Cache] fix dbindex Redis #44043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 16, 2021
Merged

[Cache] fix dbindex Redis #44043

merged 1 commit into from
Nov 16, 2021

Conversation

a1812
Copy link
Contributor

@a1812 a1812 commented Nov 14, 2021

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #43359
License MIT
Doc PR

Invalid dbindex silently not ignored in Redis DSN

@carsonbot carsonbot added this to the 4.4 milestone Nov 14, 2021
@a1812 a1812 changed the title [Cache] fix dbindex [Cache] fix dbindex Redis Nov 14, 2021
@a1812 a1812 force-pushed the fix_redis_dsn_43359 branch from 90ece4e to 9c0d57d Compare November 14, 2021 23:02
chalasr
chalasr approved these changes Nov 15, 2021
View reviewed changes
Copy link
Member

@chalasr chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't check the code, but the same issue may exist elsewhere in the codebase where we deal with redis connections (redis-messenger, lock). Might be worth having a look if you can

@fabpot fabpot force-pushed the fix_redis_dsn_43359 branch from 5c37603 to 2378a89 Compare November 16, 2021 07:28
@fabpot
Copy link
Member

fabpot commented Nov 16, 2021

Thank you @a1812.

@fabpot fabpot merged commit 94ff309 into symfony:4.4 Nov 16, 2021
@a1812 a1812 deleted the fix_redis_dsn_43359 branch November 17, 2021 01:44
This was referenced Nov 18, 2021
Merged
Merged
Merged
Merged
@mathielen mathielen mentioned this pull request Nov 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Bug Cache Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@a1812 @fabpot @chalasr @carsonbot