Skip to content

[HttpClient][Mime] Add correct IDN flags for IDNA2008 compliance #44119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 19, 2021
Merged

[HttpClient][Mime] Add correct IDN flags for IDNA2008 compliance #44119

merged 1 commit into from
Nov 19, 2021

Conversation

j-bernard
Copy link
Contributor

@j-bernard j-bernard commented Nov 17, 2021 •
edited by nicolas-grekas
Loading

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets #44091 #44092
License MIT

Fix #44091
Fix #44092

@carsonbot carsonbot added this to the 4.4 milestone Nov 17, 2021
@carsonbot carsonbot changed the title bug #44091 [HttpClient] Add correct IDN flags for IDNA2008 compliance [HttpClient] bug #44091 Add correct IDN flags for IDNA2008 compliance Nov 17, 2021
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@nicolas-grekas
Copy link
Member

Can you please fix #44092 in the same PR since that's the same topic?

@nicolas-grekas nicolas-grekas changed the title [HttpClient] bug #44091 Add correct IDN flags for IDNA2008 compliance [HttpClient] Add correct IDN flags for IDNA2008 compliance Nov 18, 2021
@j-bernard
Copy link
Contributor Author

I made the 2 updates. While making those, I noticed that in version 5.1 you allowed non-ASCII local-part without implementing RFC6531. See my bug report: #44136

@carsonbot carsonbot changed the title [HttpClient] Add correct IDN flags for IDNA2008 compliance [HttpClient][Mime] Add correct IDN flags for IDNA2008 compliance Nov 19, 2021
nicolas-grekas
nicolas-grekas approved these changes Nov 19, 2021
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(after @OskarStark's comment is fixed)

@fabpot
Copy link
Member

fabpot commented Nov 19, 2021

Thank you @j-bernard.

@fabpot fabpot merged commit bfc8b1e into symfony:4.4 Nov 19, 2021
@welcoMattic welcoMattic mentioned this pull request Nov 19, 2021
Merged
This was referenced Nov 22, 2021
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark left review comments

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Bug HttpClient Mime Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
5 participants
@j-bernard @carsonbot @nicolas-grekas @fabpot @OskarStark