[Notifier] add Vonage bridge to replace the Nexmo one #44271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
commented
Nov 25, 2021
eeda3ab to
24d09db
Compare
OskarStark
approved these changes
Nov 25, 2021
|
Would love to get some kind of validation from @SecondeJK before merging. |
|
Thanks for sorting this @nicolas-grekas. The baseURL for the API is still the same (i.e. rest.nexmo.com) but if this changes in the future I can raise it or issue a PR to make things smoother. @fabpot I'm the PHP Advocate for Vonage, formerly Nexmo - the rebranding only happened recent-ishly despite the sale being quite a while back. I guess expect we'll be bothering you a lot more re: Symfony events etc. soon! |
welcoMattic
reviewed
Nov 25, 2021
welcoMattic
approved these changes
Nov 25, 2021
24d09db to
02d1bc1
Compare
fancyweb
approved these changes
Nov 26, 2021
02d1bc1 to
a3802e2
Compare
|
Thank you @nicolas-grekas. |
This was referenced Nov 29, 2021
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@SecondeJK from Vonage reached us on Slack to tell us that Nexmo has been bought by Vonage 2 years ago.
So here we are, deprecating the nexmo bridge in favor of the vonage one.