Skip to content

Add Engagespot bridge #44303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 26, 2022
Merged

Add Engagespot bridge #44303

merged 1 commit into from
Mar 26, 2022

Conversation

danut007ro
Copy link
Contributor

@danut007ro danut007ro commented Nov 27, 2021 •
edited by OskarStark
Loading

Q A
Branch? 6.1
Bug fix? no
New feature? yes
Deprecations? no
Tickets no ticket
License MIT
Doc PR symfony/symfony-docs#16165

Add Engagespot integration for push notifications.

@carsonbot carsonbot added this to the 5.4 milestone Nov 27, 2021
@danut007ro danut007ro changed the title Engagespot notifier [Notifier] Add Engagespot bridge Nov 27, 2021
This was referenced Nov 27, 2021
Closed
Merged
OskarStark
OskarStark requested changes Nov 27, 2021
View reviewed changes
Copy link
Contributor

@OskarStark OskarStark left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution

@carsonbot carsonbot changed the title [Notifier] Add Engagespot bridge Add Engagespot bridge Nov 27, 2021
OskarStark
OskarStark approved these changes Nov 27, 2021
View reviewed changes
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After my last comment

@danut007ro
Copy link
Contributor Author

I fixed all you feedback. Thank you very much for the review

@fabpot fabpot modified the milestones: 5.4, 6.1 Nov 29, 2021
@javiereguiluz javiereguiluz mentioned this pull request Dec 8, 2021
Closed
nicolas-grekas
nicolas-grekas reviewed Mar 4, 2022
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please rebase for 6.1?

OskarStark
OskarStark reviewed Mar 4, 2022
View reviewed changes
@danut007ro
Copy link
Contributor Author

Done, but psalm is failing

@nicolas-grekas
Copy link
Member

Can you please rebase to get rid of the merge commit?
For Psalm it's unrelated so 🤷‍♂️

@danut007ro danut007ro force-pushed the engagespot-notifier branch from d1483e6 to 099add0 Compare March 5, 2022 12:19
@danut007ro
Copy link
Contributor Author

Done, hope is ok now. Psalm is still failing...

@fabpot
Copy link
Member

fabpot commented Mar 26, 2022

Thank you @danut007ro.

@fabpot fabpot force-pushed the engagespot-notifier branch from 099add0 to c7e1d1a Compare March 26, 2022 11:30
@fabpot fabpot merged commit 50749dd into symfony:6.1 Mar 26, 2022
@fabpot fabpot mentioned this pull request Apr 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@OskarStark OskarStark OskarStark approved these changes

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Feature Status: Reviewed
Projects
None yet
Milestone
6.1
Development

Successfully merging this pull request may close these issues.
5 participants
@danut007ro @nicolas-grekas @fabpot @OskarStark @carsonbot