[HttpKernel] Fix wrong usage of SessionUtils::popSessionCookie #44437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexander-schranz could you please check if this works for you on #41390 ? |
|
Hey! I think @mtarld has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
derrabus
approved these changes
Dec 6, 2021
There was a problem hiding this comment.
LGTM
@alexander-schranz Since this changes code you've contributed, can you please verify that this change works for you?
alexander-schranz
approved these changes
Dec 6, 2021
There was a problem hiding this comment.
Looks correct for me. Did test it also with roadrunner on symfony demo and the php runtime. Session there works still as expected.
|
Thank you @simonchrz for taking care of this regression. |
|
@simonchrz Thx for fixing this 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function onKernelResponse() removes possible Set-Cookie headers from headers_list by using SessionUtils::popSessionCookie($sessionName, $sessionCookiePath);
https://github.com/symfony/symfony/blob/5.4/src/Symfony/Component/HttpKernel/EventListener/AbstractSessionListener.php#L149
2nd expected parameter of SessionUtils::popSessionCookie function is the sessionId, not the $sessionCookiePath
https://github.com/symfony/symfony/blob/v5.4.0/src/Symfony/Component/HttpFoundation/Session/SessionUtils.php#L28