Skip to content

[HttpFoundation] Update cookie date time format #44543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2021

Conversation

chapterjason
Copy link
Contributor

@chapterjason chapterjason commented Dec 9, 2021

Q A
Branch? 6.1
Bug fix? no
New feature? no
Deprecations? no
Tickets Fix #41606
License MIT
Doc PR

Wasn't sure if it will be a bug, feature and/or deprecation according to the issue. 😄

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@chapterjason chapterjason changed the title Update cookie date time format [HttpFoundation] Update cookie date time format Dec 9, 2021
@GromNaN
Copy link
Member

GromNaN commented Dec 10, 2021

This is actually a feature. Can you add a note to the changelog of the component?

Copy link
Member

@fabpot fabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is purely internal, I don't think we need a changelog item.

@fabpot
Copy link
Member

fabpot commented Dec 11, 2021

Thank you @chapterjason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

symfony/http-foundation's cooke expire date is not standard format.
5 participants