Skip to content

[DependencyInjection] Cast tag attribute value to string #44639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 17, 2021
Merged

[DependencyInjection] Cast tag attribute value to string #44639

merged 1 commit into from
Dec 17, 2021

Conversation

ruudk
Copy link
Contributor

@ruudk ruudk commented Dec 15, 2021 •
edited
Loading

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR 
DOMElement::setAttribute(): Passing null to parameter #2 ($value) of type string is deprecated

This happens when a tag value is null on PHP 8.1.

@carsonbot carsonbot added this to the 4.4 milestone Dec 15, 2021
@carsonbot carsonbot changed the title [DependencyInjection][PHP 8.1] Cast tag value to string to fix: DOMElement::setAttribute(): Passing null to parameter #2 ($value) of type string is deprecated [DependencyInjection] [PHP 8.1] Cast tag value to string to fix: DOMElement::setAttribute(): Passing null to parameter #2 ($value) of type string is deprecated Dec 15, 2021
@ruudk ruudk force-pushed the set-attribute-nullable-php-81 branch from 59c0a3d to 26e56fb Compare December 15, 2021 11:58
@ruudk
[DependencyInjection] Cast tag value to string
8fe5fce 
DOMElement::setAttribute(): Passing null to parameter symfony#2 ($value) of type string is deprecated

This happens when a tag value is `null` on PHP 8.1.
@ruudk ruudk force-pushed the set-attribute-nullable-php-81 branch from 26e56fb to 8fe5fce Compare December 15, 2021 12:10
@derrabus derrabus changed the title [DependencyInjection] [PHP 8.1] Cast tag value to string to fix: DOMElement::setAttribute(): Passing null to parameter #2 ($value) of type string is deprecated [DependencyInjection] Cast tag attribute value to string Dec 15, 2021
@derrabus derrabus mentioned this pull request Dec 15, 2021
Closed
@fabpot
Copy link
Member

fabpot commented Dec 17, 2021

Thank you @ruudk.

@fabpot fabpot merged commit f2cac74 into symfony:4.4 Dec 17, 2021
@ruudk ruudk deleted the set-attribute-nullable-php-81 branch December 17, 2021 16:51
This was referenced Dec 29, 2021
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@derrabus derrabus derrabus approved these changes

Assignees
No one assigned
Labels
Bug DependencyInjection Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@ruudk @fabpot @derrabus @carsonbot