[Translation] Translatable parameters #44672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9f42cc7 to
7a0b2fc
Compare
nicolas-grekas
approved these changes
Dec 17, 2021
There was a problem hiding this comment.
LGTM after some minor comments are addressed.
I would like also to add TranslatableInterface to the trans(?string $id) signature method like with the one from the TwigExtension but I don't know how to do it without breaking BC. Any advice is welcome!
I can't think of any appropriate BC layer (renaming the method is not an appropriate way :) )
I think it's fine not supporting this personnaly.
7a0b2fc to
16b6723
Compare
16b6723 to
5beaee8
Compare
|
Thank you @nicolas-grekas for your review, I've fixed your comments |
nicolas-grekas
approved these changes
Dec 17, 2021
fabpot
approved these changes
Dec 17, 2021
|
Thank you @sylfabre. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ The TwigExtension now supports messages implementing
TranslatableInterface(https://symfony.com/blog/new-in-symfony-5-2-translatable-objects).✅ Thanks to #41858,
TranslatableMessagenow supports recursiveTranslatableInterfaceas params.❌ But using
TranslatableInterfaceas params with regular messages is not supported yet.💡 This PR addresses this issue and makes it possible to create dedicated
TranslatableInterfaceimplementations like the one from #41136Note: I would like also to add
TranslatableInterfaceto thetrans(?string $id)signature method like with the one from the TwigExtension but I don't know how to do it without breaking BC. Any advice is welcome!