Skip to content

[Security] A sprintf is missing #44808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 27, 2021
Merged

[Security] A sprintf is missing #44808

merged 1 commit into from
Dec 27, 2021

Conversation

helmis123
Copy link
Contributor

@helmis123 helmis123 commented Dec 27, 2021

A sprintf is missing when throw a LogicException in the constructor of AuthorizationChecker class.

Q A
Branch? 6.1 for features / 6.0, 6.1 for bug fixes
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #...
License MIT
Doc PR symfony/symfony-docs#...

A sprintf is missing when throw a LogicException in the constructor of AuthorizationChecker class.
@helmis123 helmis123 changed the title A sprintf is missing [Security] A sprintf is missing Dec 27, 2021
@wouterj
Copy link
Member

wouterj commented Dec 27, 2021

Good catch, thanks @helmis123.

@wouterj wouterj merged commit 37de878 into symfony:6.0 Dec 27, 2021
fabpot added a commit that referenced this pull request Dec 28, 2021
…ault)

This PR was squashed before being merged into the 6.0 branch.

Discussion
----------

[Mime][Security] Fix missing sprintf and add tests

| Q             | A
| ------------- | ---
| Branch?       | 6.0
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

#44808 fix one missing sprintf. This PR fix other cases and add tests.

Commits
-------

c1954f8 [Mime][Security] Fix missing sprintf and add tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants