Skip to content

[Yaml] Making the parser stateless #45140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 25, 2022
Merged

[Yaml] Making the parser stateless #45140

merged 1 commit into from
Jan 25, 2022

Conversation

mamazu
Copy link
Contributor

@mamazu mamazu commented Jan 23, 2022

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Currently if you parse multiple files with the same Parser instance, you get different results in the error reporting since the parser doesn't reset the offset.

How to reproduce

If you remove the line added in the parser then the error message shows the incorrect line number and the test will fail.

@mamazu mamazu requested a review from xabbuh as a code owner January 23, 2022 22:14
@carsonbot carsonbot added this to the 4.4 milestone Jan 23, 2022
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@derrabus derrabus added the Yaml label Jan 23, 2022
@carsonbot carsonbot changed the title Making the parser stateless [Yaml] Making the parser stateless Jan 23, 2022
stof
stof reviewed Jan 24, 2022
View reviewed changes
Copy link
Member

@stof stof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the properties, the reset is also missing for refsBeingParsed

@mamazu
Copy link
Contributor Author

mamazu commented Jan 24, 2022

This is true and on some objects the offset is getting reset back to 0. I haven't really dug into the code of the parser.

@mamazu
Copy link
Contributor Author

mamazu commented Jan 24, 2022

Should I also add a reset for the refsBeingParsed even though I don't know how to reproduce the error in a test?

@nicolas-grekas
Copy link
Member

Yes please

@fabpot
Copy link
Member

fabpot commented Jan 25, 2022

Thank you @mamazu.

@fabpot fabpot merged commit 8ba3fa7 into symfony:4.4 Jan 25, 2022
@mamazu mamazu deleted the 4.4 branch January 25, 2022 11:04
This was referenced Jan 28, 2022
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof left review comments

@fabpot fabpot fabpot approved these changes

@kbond kbond kbond approved these changes

@chalasr chalasr chalasr approved these changes

@xabbuh xabbuh Awaiting requested review from xabbuh xabbuh is a code owner

Assignees
No one assigned
Labels
Bug Status: Reviewed Yaml
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
8 participants
@mamazu @carsonbot @nicolas-grekas @fabpot @kbond @stof @chalasr @derrabus