From 27d9efff9b6959d079269c00bcc193ffbde4ae3f Mon Sep 17 00:00:00 2001
From: Thomas Nunninger <thomas.nunninger@scaleupventures.com>
Date: Mon, 24 Jan 2022 12:56:09 +0100
Subject: [PATCH] [Serializer] Fix AbstractObjectNormalizer not considering
 pseudo type false

---
 .../Normalizer/AbstractObjectNormalizer.php   |  4 ++++
 .../Tests/Normalizer/ObjectNormalizerTest.php | 20 +++++++++++++++++++
 .../Component/Serializer/Tests/Php80Dummy.php | 19 ++++++++++++++++++
 3 files changed, 43 insertions(+)
 create mode 100644 src/Symfony/Component/Serializer/Tests/Php80Dummy.php

diff --git a/src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php
index b01c529dbc283..f6f7e5fb653a2 100644
--- a/src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php
+++ b/src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php
@@ -537,6 +537,10 @@ private function validateAndDenormalize(string $currentClass, string $attribute,
                 return (float) $data;
             }
 
+            if (Type::BUILTIN_TYPE_FALSE === $builtinType && false === $data) {
+                return $data;
+            }
+
             if (('is_'.$builtinType)($data)) {
                 return $data;
             }
diff --git a/src/Symfony/Component/Serializer/Tests/Normalizer/ObjectNormalizerTest.php b/src/Symfony/Component/Serializer/Tests/Normalizer/ObjectNormalizerTest.php
index d60571307b18a..38436e284b029 100644
--- a/src/Symfony/Component/Serializer/Tests/Normalizer/ObjectNormalizerTest.php
+++ b/src/Symfony/Component/Serializer/Tests/Normalizer/ObjectNormalizerTest.php
@@ -50,6 +50,7 @@
 use Symfony\Component\Serializer\Tests\Normalizer\Features\ObjectToPopulateTestTrait;
 use Symfony\Component\Serializer\Tests\Normalizer\Features\SkipNullValuesTestTrait;
 use Symfony\Component\Serializer\Tests\Normalizer\Features\TypeEnforcementTestTrait;
+use Symfony\Component\Serializer\Tests\Php80Dummy;
 
 /**
  * @author Kévin Dunglas <dunglas@gmail.com>
@@ -699,6 +700,25 @@ public function testExtractAttributesRespectsContext()
         $this->assertSame(['foo' => 'bar', 'bar' => 'foo'], $normalizer->normalize($data, null, ['include_foo_and_bar' => true]));
     }
 
+    /**
+     * @requires PHP 8
+     */
+    public function testDenormalizeFalsePseudoType()
+    {
+        // given a serializer that extracts the attribute types of an object via ReflectionExtractor
+        $propertyTypeExtractor = new PropertyInfoExtractor([], [new ReflectionExtractor()], [], [], []);
+        $objectNormalizer = new ObjectNormalizer(null, null, null, $propertyTypeExtractor);
+
+        $serializer = new Serializer([$objectNormalizer]);
+
+        // when denormalizing some data into an object where an attribute uses the false pseudo type
+        /** @var Php80Dummy $object */
+        $object = $serializer->denormalize(['canBeFalseOrString' => false], Php80Dummy::class);
+
+        // then the attribute that declared false was filled correctly
+        $this->assertFalse($object->canBeFalseOrString);
+    }
+
     public function testAdvancedNameConverter()
     {
         $nameConverter = new class() implements AdvancedNameConverterInterface {
diff --git a/src/Symfony/Component/Serializer/Tests/Php80Dummy.php b/src/Symfony/Component/Serializer/Tests/Php80Dummy.php
new file mode 100644
index 0000000000000..06c4c4dd1328e
--- /dev/null
+++ b/src/Symfony/Component/Serializer/Tests/Php80Dummy.php
@@ -0,0 +1,19 @@
+<?php
+
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Fabien Potencier <fabien@symfony.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+namespace Symfony\Component\Serializer\Tests;
+
+final class Php80Dummy
+{
+    public false|string $canBeFalseOrString;
+}