Skip to content

[Dotenv] Fix bootEnv() override with .env.local.php when the env key already exists #45188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 26, 2022
Merged

[Dotenv] Fix bootEnv() override with .env.local.php when the env key already exists #45188

merged 1 commit into from
Jan 26, 2022

Conversation

fancyweb
Copy link
Contributor

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

If $_SERVER['APP_ENV'] = 'foo' and .env.local.php exists and returns 'APP_ENV' => 'prod', the override does not work.

@carsonbot carsonbot added this to the 5.4 milestone Jan 26, 2022
@nicolas-grekas
Copy link
Member

Thank you @fancyweb.

@nicolas-grekas nicolas-grekas merged commit 9b7aac3 into symfony:5.4 Jan 26, 2022
@fancyweb fancyweb deleted the dotenv/boot-env-overr-fix branch January 26, 2022 16:37
This was referenced Jan 28, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Dotenv Status: Needs Review
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@fancyweb @nicolas-grekas @carsonbot