Skip to content

Fix session test cases for symfony #45192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 27, 2022
Merged

Fix session test cases for symfony #45192

merged 1 commit into from
Jan 27, 2022

Conversation

alexander-schranz
Copy link
Contributor

@alexander-schranz alexander-schranz commented Jan 26, 2022 •
edited by nicolas-grekas
Loading

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Related to: #44634

Fix HttpKernel test cases as session are created differently in symfony 6.0.

@carsonbot carsonbot added this to the 6.0 milestone Jan 26, 2022
@alexander-schranz alexander-schranz force-pushed the bugfix/session-6-0-test-cases branch from b464f18 to 4fc091e Compare January 26, 2022 18:59
@alexander-schranz alexander-schranz changed the title WIP: Fix session test cases for symfony 6 Fix session test cases for symfony 6 Jan 26, 2022
@alexander-schranz alexander-schranz mentioned this pull request Jan 26, 2022
Merged
1 task
@alexander-schranz alexander-schranz force-pushed the bugfix/session-6-0-test-cases branch 2 times, most recently from 3d860e9 to 9859200 Compare January 26, 2022 19:02
@alexander-schranz alexander-schranz changed the title Fix session test cases for symfony 6 [HttpKernel] Fix session test cases for symfony 6 Jan 26, 2022
@alexander-schranz
Copy link
Contributor Author

alexander-schranz commented Jan 26, 2022 •
edited
Loading

@nicolas-grekas there seems also some Lock test which I'm not familiar with which are failing currently.

@nicolas-grekas nicolas-grekas changed the title [HttpKernel] Fix session test cases for symfony 6 [HttpKernel] Fix session test cases for symfony Jan 27, 2022
@nicolas-grekas nicolas-grekas modified the milestones: 6.0, 5.4 Jan 27, 2022
@nicolas-grekas nicolas-grekas changed the base branch from 6.0 to 5.4 January 27, 2022 09:55
@nicolas-grekas nicolas-grekas force-pushed the bugfix/session-6-0-test-cases branch from 9859200 to b047a2d Compare January 27, 2022 09:55
@carsonbot carsonbot changed the title [HttpKernel] Fix session test cases for symfony Fix session test cases for symfony Jan 27, 2022
@nicolas-grekas
Copy link
Member

Thank you @alexander-schranz.

@nicolas-grekas nicolas-grekas merged commit bca341f into symfony:5.4 Jan 27, 2022
@alexander-schranz alexander-schranz deleted the bugfix/session-6-0-test-cases branch January 27, 2022 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalasr chalasr Awaiting requested review from chalasr

@dunglas dunglas Awaiting requested review from dunglas

@jderusse jderusse Awaiting requested review from jderusse

@lyrixx lyrixx Awaiting requested review from lyrixx

@OskarStark OskarStark Awaiting requested review from OskarStark

@wouterj wouterj Awaiting requested review from wouterj

@xabbuh xabbuh Awaiting requested review from xabbuh

@yceruto yceruto Awaiting requested review from yceruto

Assignees
No one assigned
Labels
Bug Status: Needs Review
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@alexander-schranz @nicolas-grekas @carsonbot