-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Notifier] Add Sendberry notifier bridge #45195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/Symfony/Component/Notifier/Bridge/Sendberry/SendberryTransport.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Notifier/Bridge/Sendberry/SendberryTransportFactory.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments, thanks for your contribution.
Please add a docs and recipes PR 👍
Thanks for your time. I updated my code and prepared recipes and docs. |
@welcoMattic you are right. We do not need to validate "from" at all. They validate ourselves. We catch this with
|
src/Symfony/Component/Notifier/Bridge/Sendberry/SendberryTransport.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Notifier/Bridge/Sendberry/SendberryTransport.php
Outdated
Show resolved
Hide resolved
@nicolas-grekas thanks. Made small changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know anyone at Sendberry that you back the bridge? Would you like to reach them about that?
I am just found them on the internet. I can try to send the link to your blog post :) |
Thank you @StaffNowa. |
Sendberry notifier https://www.sendberry.com/