[Serializer] Support canners in object normalizer #45282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! I think @mtarld has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
OskarStark
reviewed
Feb 5, 2022
84271d9 to
957de4b
Compare
957de4b to
60ee9ed
Compare
cfdafae to
b88d43c
Compare
61d2e0b to
02d6105
Compare
02d6105 to
d1f643d
Compare
d1f643d to
18bc5e3
Compare
EmilMassey
approved these changes
Apr 16, 2022
18bc5e3 to
c3cb4f5
Compare
|
It's been hanging for a while, is there any issues with this PR? |
mtarld
approved these changes
Apr 27, 2022
fabpot
approved these changes
Apr 27, 2022
nicolas-grekas
approved these changes
Apr 27, 2022
|
Thank you @rmikalkenas. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that serializer is not capable of normalizing properties with methods that start with
canprefix, even though property info component has support for it. I think it's inconsistent and serializer should support it as well.Targeting 6.1 branch as this sounds like a new feature (correct me if wrong). Also not sure about BC as this change might break others code (until this change, properties with can methods were silently skipped from normalization)