Skip to content

[Security/Http] Fix getting password-upgrader when user-loader is a closure #45463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2022
Merged

[Security/Http] Fix getting password-upgrader when user-loader is a closure #45463

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Symfony/Component/Security/Http/EventListener/PasswordMigratingListener.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,9 @@ public function onLoginSuccess(LoginSuccessEvent $event): void
$userLoader = $userBadge->getUserLoader();
if (\is_array($userLoader) && $userLoader[0] instanceof PasswordUpgraderInterface) {
$passwordUpgrader = $userLoader[0];
} else {
} elseif (!$userLoader instanceof \Closure
|| !($passwordUpgrader = (new \ReflectionFunction($userLoader))->getClosureThis()) instanceof PasswordUpgraderInterface
) {
return;
}
}
Expand Down
5 changes: 4 additions & 1 deletion src/Symfony/Component/Security/Http/Tests/EventListener/PasswordMigratingListenerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,13 +111,16 @@ public function testUpgradeWithoutUpgrader()
$userLoader = $this->getMockForAbstractClass(TestMigratingUserProvider::class);
$userLoader->expects($this->any())->method('loadUserByIdentifier')->willReturn($this->user);

$userLoader->expects($this->once())
$userLoader->expects($this->exactly(2))
->method('upgradePassword')
->with($this->user, 'new-hash')
;

$event = $this->createEvent(new SelfValidatingPassport(new UserBadge('test', [$userLoader, 'loadUserByIdentifier']), [new PasswordUpgradeBadge('pa$$word')]));
$this->listener->onLoginSuccess($event);

$event = $this->createEvent(new SelfValidatingPassport(new UserBadge('test', \Closure::fromCallable([$userLoader, 'loadUserByIdentifier'])), [new PasswordUpgradeBadge('pa$$word')]));
$this->listener->onLoginSuccess($event);
}

public function testUserWithoutPassword()
Expand Down