Skip to content

[Validator] Deprecate constraint "ExpressionLanguageSyntax", use "ExpressionSyntax" instead #45623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2022

Conversation

mpiot
Copy link
Contributor

@mpiot mpiot commented Mar 3, 2022

Q A
Branch? 6.1
Bug fix? yes
New feature? yes
Deprecations? yes
Tickets Fix
License MIT
Doc PR

Like other validators, ExpressionLanguageSyntax validator should be ignored when the value is null or receive an empty string, add NotNull or NotBlank if needed. In #41329 @nicolas-grekas proposed to create a new one called ExpressionSyntax and deprecate ExpressionLanguageSyntax validator.

@carsonbot carsonbot added this to the 6.1 milestone Mar 3, 2022
@nicolas-grekas nicolas-grekas changed the title [Validator] ExpressionLanguageSyntax replacement [Validator] Deprecate constraint "ExpressionLanguageSyntax", use "ExpressionSyntax" instead Mar 4, 2022
@nicolas-grekas nicolas-grekas force-pushed the expression-syntax branch 2 times, most recently from 3f6093d to 847dc3a Compare March 4, 2022 08:45
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I made a few minor changes)

@nicolas-grekas
Copy link
Member

Thank you @mpiot.

@nicolas-grekas nicolas-grekas merged commit 25a5eb2 into symfony:6.1 Mar 4, 2022
@fabpot fabpot mentioned this pull request Apr 15, 2022
javiereguiluz added a commit to symfony/symfony-docs that referenced this pull request Dec 13, 2022
…pressionSyntax (MrYamous)

This PR was merged into the 6.1 branch.

Discussion
----------

[Validator] replace expressionLanguageSyntax with new expressionSyntax

As expressionSyntax deprecates expressionLanguageSyntax, replace it from constraint's list

[Related code PR](symfony/symfony#45623)

Commits
-------

3a35ff2 validator - replace expressionLanguageSyntax with new expressionSyntax
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants