[Form] Fix same choice loader with different choice values #46098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b41d306 to
b2bd85d
Compare
|
When working on #46030 I stumbled over the tests for For the other changes here I am not sure that this really is the way to go. If I am not missing anything we don't have anything that states that a |
7785c35 to
07252a4
Compare
xabbuh
approved these changes
May 20, 2022
07252a4 to
65cbf18
Compare
|
Thank you Jules. |
This was referenced May 27, 2022
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that deprecating the caching in the
LazyChoiceList(cf #18359) was a mistake. The bug went under the radar because in practice every choice field has its own loader instance.However, optimizations made in #30994 then revealed the flaw (cf #42206) as the loaders were actually shared across many fields.
While working on a fix I ended up implementing something similar to what's proposed in #44655.
I'll send a PR for 5.4 as well.