Skip to content

[Console] Complete negatable options (Fish) #46387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2022

Conversation

GromNaN
Copy link
Member

@GromNaN GromNaN commented May 17, 2022

Q A
Branch? 6.1
Bug fix? yes
New feature? no
Deprecations? no
Tickets n/a
License MIT
Doc PR n/a

Same as #46386 for Fish (introduced in 6.1).

@GromNaN GromNaN requested a review from chalasr as a code owner May 17, 2022 21:12
@carsonbot carsonbot added this to the 6.1 milestone May 17, 2022
@carsonbot carsonbot changed the title [Console] Complete negatable options (Fish) [Console] Complete negatable options (Fish) May 17, 2022
@GromNaN GromNaN requested a review from wouterj May 17, 2022 21:16
@GromNaN GromNaN force-pushed the complete-negatable-6.1 branch 3 times, most recently from e7e0485 to 81bbfba Compare May 18, 2022 06:21
@fabpot
Copy link
Member

fabpot commented May 18, 2022

Should be done in 6.2 as this is a new feature.

@fabpot fabpot modified the milestones: 6.1, 6.2 May 20, 2022
@nicolas-grekas nicolas-grekas changed the base branch from 6.2 to 6.1 May 20, 2022 14:20
@nicolas-grekas nicolas-grekas modified the milestones: 6.2, 6.1 May 20, 2022
@fabpot
Copy link
Member

fabpot commented May 27, 2022

Thank you @GromNaN.

@fabpot fabpot force-pushed the complete-negatable-6.1 branch from 81bbfba to 02b7b52 Compare May 27, 2022 06:34
@fabpot fabpot merged commit 5eb4306 into symfony:6.1 May 27, 2022
fabpot added a commit that referenced this pull request May 27, 2022
…ions in shell completion (GromNaN)

This PR was merged into the 5.4 branch.

Discussion
----------

[Console]  Fix missing negative variation of negatable options in shell completion

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | n/a
| License       | MIT
| Doc PR        | n/a

Add negation of [negatable options](https://symfony.com/blog/new-in-symfony-5-3-negatable-command-options) in bash completion output.

2nd PR for Fish, targeting branch 6.1: #46387

Commits
-------

a3da680 Complete negatable options
@fabpot fabpot mentioned this pull request May 27, 2022
@GromNaN GromNaN deleted the complete-negatable-6.1 branch May 27, 2022 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants