Skip to content

[Security] Make #[IsGranted] final #46915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 12, 2022
Merged

[Security] Make #[IsGranted] final #46915

merged 1 commit into from
Jul 12, 2022

Conversation

chalasr
Copy link
Member

@chalasr chalasr commented Jul 12, 2022

Q A
Branch? 6.2
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Also make use of security-core domain's RuntimeException.

@chalasr chalasr requested a review from wouterj as a code owner July 12, 2022 10:11
@carsonbot carsonbot added this to the 6.2 milestone Jul 12, 2022
@chalasr chalasr mentioned this pull request Jul 12, 2022
Merged
@stof
Copy link
Member

stof commented Jul 12, 2022

Btw, we should probably check our other attributes too, to see whether our usages are supporting inheritance or no.

@chalasr
Copy link
Member Author

chalasr commented Jul 12, 2022

Indeed it's quite inconsistent right now, I'll check them all in another PR.

@chalasr chalasr merged commit fa24df6 into symfony:6.2 Jul 12, 2022
@chalasr chalasr deleted the isgranted-tweaks branch July 12, 2022 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof approved these changes

@wouterj wouterj Awaiting requested review from wouterj wouterj is a code owner

Assignees
No one assigned
Labels
Security Status: Reviewed
Projects
None yet
Milestone
6.2
Development

Successfully merging this pull request may close these issues.
3 participants
@chalasr @stof @carsonbot