[Validator] Add additional hint when egulias/email-validator needs to be installed
#47189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for strict mode as default config
|
What about also performing this check in the configuration itself? |
|
That might throw the exception also when the |
|
Yeah, you are right. Probably it's better play safe here and not do that as a bugfix. |
xabbuh
approved these changes
Aug 5, 2022
|
Thank you @mpdude. |
This was referenced Aug 26, 2022
Merged
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
Symfony\Component\Validator\Constraints\Emailconstraint with'mode' => 'strict', a helpful error message is shown when the necessary package is not installed.However, when configuring
strictmode as a framework setting (https://symfony.com/doc/current/reference/configuration/framework.html#email-validation-mode) and omitting themodesetting on the constraint itself, that message was missing.