Skip to content

[HttpFoundation] prevent incomplete profile dumps #47281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

DennisBirkholz
Copy link

@DennisBirkholz DennisBirkholz commented Aug 15, 2022

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #47280
License MIT

Write profile dump into tempfile and rename it after it is completely written to prevent loading incomplete profile dumps.

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot carsonbot changed the title bug #47280: [HttpFoundation] prevent incomplete profile dumps [HttpFoundation] bug #47280: prevent incomplete profile dumps Aug 15, 2022
@fabpot fabpot modified the milestones: 6.2, 4.4 Aug 19, 2022
@fabpot
Copy link
Member

fabpot commented Aug 19, 2022

This should be for 4.4 as the referenced PR was merged in 4.4, right?

@DennisBirkholz
Copy link
Author

This should be for 4.4 as the referenced PR was merged in 4.4, right?

Right, this should be for all versions #46931 was merged into. We currently use 5.4 so I referenced only that version.

@DennisBirkholz DennisBirkholz changed the base branch from 6.2 to 4.4 August 22, 2022 15:17
@nicolas-grekas nicolas-grekas changed the title [HttpFoundation] bug #47280: prevent incomplete profile dumps [HttpFoundation] prevent incomplete profile dumps Aug 30, 2022
@nicolas-grekas
Copy link
Member

In #47435, I propose to add a lock instead.

@nicolas-grekas
Copy link
Member

Closing in favor of #47435, which should provide a bit better experience when race conditions happen.
Thanks for submitting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HttpFoundation: race condition introduced by #46931 breaks Web Profiler Bar
5 participants